Updated: Comment #N

Problem/Motivation

While profiling I figured out that getFileName() and rules_core_modules() are called quite often and could profit from static caching.

Proposed resolution

Well, static caching as implemented in the patch.

Remaining tasks

Reviews needed.

User interface changes

None

API changes

None

CommentFileSizeAuthor
rules-add-static-caching.patch3.47 KBdas-peter

Comments

ndobromirov’s picture

ndobromirov commented
Status: Needs review » Reviewed & tested by the community

Seems OK, nothing structural is changed, except the added caches, so changing to RTBC.
Can you provide example XHProf outputs (before/after)?

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

Makes sense and passes tests, thus committed - thanks.

  • fago committed 2373c92 on 7.x-2.x authored by das-peter 
    Issue #2200717 by das-peter: Add more static caching

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.