The Syntax check currently runs against any modified files; be it a deleted file, in the vendor dir, an image, etc.

Comments

isntall created an issue. See original summary.

  • isntall committed b12f295 on 2603092-syntax-check-needs-contraints 
    Issue #2603092 by isntall: syntax check needs contraints

  • isntall committed 06eff4f on 2603092-syntax-check-needs-contraints 
    Issue #2603092 by isntall: syntax check needs contraints, switching to...
isntall’s picture

isntall commented
Status: Active » Needs review

Could use some testing.

  • isntall committed 3449622 on 2603092-syntax-check-needs-contraints 
    Issue #2603092 by isntall: syntax check needs constraints, moving more...
isntall’s picture

isntall commented
Title: syntax check needs contraints » syntax check needs constraints

  • isntall committed 06eff4f on 2603092-syntax-check-needs-constraints 
    Issue #2603092 by isntall: syntax check needs contraints, switching to...
  • isntall committed 3449622 on 2603092-syntax-check-needs-constraints
    Issue #2603092 by isntall: syntax check needs constraints, moving more...
  • isntall committed b12f295 on 2603092-syntax-check-needs-constraints
    Issue #2603092 by isntall: syntax check needs contraints
  • isntall committed c2ba7b4 on 2603092-syntax-check-needs-constraints
    Issue #2603092 by isntall: syntax check needs constraints, using correct...
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

These look good. We're going to want to refactor some more things like:

XML output for passes/fails
Moving the syntax linting to a JobType

Otherwise, this will now syntax lint.

isntall’s picture

isntall commented
Issue tags: +Needs deployment

Merged into dev.

isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs deployment

dev has been merged into production, and pushed into production.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.