Deprecated methods need to be modified
admin_toolbar_tools/src/Controller/ToolbarController.php
tests/src/Functional/AdminToolbarAlterTest.php

CommentFileSizeAuthor
#7 replaced_test_deprecated_methods-3031310-7.patch623 bytesabhisekmazumdar
#2 deprecated_methods_removed-3031310-2.patch1.26 KBakshay_d

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Location Bangalore
commented
StatusFileSize
new deprecated_methods_removed-3031310-2.patch1.26 KB

deprecated methods removed

akshay_d’s picture

akshay_d
Location Bangalore
commented
Status: Active » Needs review

deprecated methods removed

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

Hi @akshay_d thanks for reporting, can you use the Issue Summary Template the next time?

The menu method will be replaced in #3027542: Admin Toolbar: Drupal 9 readiness / compatibility, so just update the issue and the patch to handler here the deprecated method on the test.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs review » Needs work
abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Assigned: Unassigned » abhisekmazumdar

Will be re-rolling the patch for the deprecated method on the test file.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Assigned: abhisekmazumdar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new replaced_test_deprecated_methods-3031310-7.patch623 bytes

Hi,
I would like to thanks @akshay_d for the patch. And also as suggested by @adriancid I have replaced the deprecated method on the test file.
Thank You

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Title: Deprecated methods needs to be modified. » Replace deprecated method assertRaw
Status: Needs review » Reviewed & tested by the community

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks to @all for the issue and the patches

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.