I found the below issue while check through drupal-check tool.

drupal-check -ad web/modules/contrib/admin_toolbar
11/11 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -----------------------------------------------------------------------------------------------------------------------
Line admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks.php
------ -----------------------------------------------------------------------------------------------------------------------
55 Constructor of class Drupal\admin_toolbar_tools\Plugin\Derivative\ExtraLinks has an unused parameter $base_plugin_id.
------ -----------------------------------------------------------------------------------------------------------------------

[ERROR] Found 1 error

CommentFileSizeAuthor
#2 admin_toolbar-unused-parameter-3109978-#2-8.x-2.0.png19.65 KBvsujeetkumar
#2 admin_toolbar-unused-parameter-3109978-#2-8.x-2.0.patch1.13 KBvsujeetkumar

Comments

vsujeetkumar created an issue. See original summary.

vsujeetkumar’s picture

vsujeetkumar commented
StatusFileSize
new admin_toolbar-unused-parameter-3109978-#2-8.x-2.0.patch1.13 KB
new admin_toolbar-unused-parameter-3109978-#2-8.x-2.0.png19.65 KB

Adding a patch that will remove the unused variable error for admin_toolbar_tools module.

vsujeetkumar’s picture

vsujeetkumar commented
Status: Active » Needs review
vsujeetkumar’s picture

vsujeetkumar commented
Assigned: vsujeetkumar » Unassigned
idebr’s picture

idebr commented
Status: Needs review » Needs work 
+++ b/admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks.php
@@ -53,6 +60,7 @@ class ExtraLinks extends DeriverBase implements ContainerDeriverInterface {
   public function __construct($base_plugin_id, EntityTypeManagerInterface $entity_type_manager, ModuleHandlerInterface $module_handler, RouteProviderInterface $route_provider, ThemeHandlerInterface $theme_handler) {
+    $this->basePluginId = $base_plugin_id;

Instead of an unused variable, we now have an unused class property.

How about we remove the variable from the ::create() return value instead?

idebr’s picture

idebr commented
Issue tags: -Drupal 9 compatibility

  • adriancid committed 8670706 on 8.x-2.x 
    Issue #3109978 by vsujeetkumar, idebr, adriancid: Unused parameter $...
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs work » Fixed

Thanks for the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.