With php 5.4+ the backup_migrate-6.x-2.x module emits a php warning and there is a patch in #2329655-14: PHP 5.4 strict warning: Only variables should be passed by reference in backup_migrate\includes\crud.inc on line 269 that applies to both 2.x and 3.x and may be better than the patch committed to 3.x-dev as it is the same as the approach taken in 7.x-3.x
The statistics for December 2018 showing over 4,600 sites using 6.x-2.8 release and there is a D6LTS fork with a 2.9 release where this is still an issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | backup_migrate-3022206-2-php-warning-only-pass-variables-by-reference.patch | 526 bytes | izmeez |
Comments
Comment #2
izmeez commentedThe attached patch has been copied from #2329655-14: PHP 5.4 strict warning: Only variables should be passed by reference in backup_migrate\includes\crud.inc on line 269 it applies to 6.x-2.9 as is required for php 7.2+ compatibility.
The attached patch may be a better patch not only for backup_migrate-6.x-2.x but also for 6.x-3.x where a previous patch from #2329655-1: PHP 5.4 strict warning: Only variables should be passed by reference in backup_migrate\includes\crud.inc on line 269 was committed to 6.x-3.x-dev only.
This patch is exactly what is in backup_migrate-7.x-3.x and follows up on the comment in #2329655-6: PHP 5.4 strict warning: Only variables should be passed by reference in backup_migrate\includes\crud.inc on line 269
Comment #3
izmeez commentedComment #4
roderikThis code is definitely good, complete to solve the issue, and without side effects.
Comment #5
dsnopekThanks!
Committed:
https://github.com/d6lts/backup_migrate/commit/6d1e4bb80582fe287d5fb4b8b...