Problem/Motivation

Running code sniffer on D6LTS reports:

-------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 10745 ERRORS AND 1439 WARNINGS WERE FOUND IN 300 FILES
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX 8216 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

Many of these are cosmetic although some include improvements in fixing occurrences of "else if" and changing them to "elseif". But, is it really worth doing this?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

izmeez created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

I don't think it's worth doing. Every line we change potentially breaks someone's custom patch, or makes backporting D7 patches harder, or breaks folks stuck on PHP 5.2, etc.

So, we're trying to only change the minimum of code, except in the cases where the change is really high value (ex. adding support for MySQL 8). Fixing all of these issues would mean lots and lots of changes with very low value.

izmeez’s picture

izmeez commented
Status: Active » Closed (won't fix)

Yes, agree. Chose to do the same. Marking as closed, won't fix.