Problem/Motivation

SelectionTest makes no HTTP requests but is a functional test

Proposed resolution

Convert SelectionTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3046018-2.patch9.26 KBclaudiu.cristea

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
StatusFileSize
new 3046018-2.patch9.26 KB

This patch decreases the locally test run from 25.1 to 2.2 seconds.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Looks great, no loss of coverage I can see.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3046018-2.patch, failed testing. View results

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Reviewed & tested by the community

?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

@Lendude, it was a random failure.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented

I added the issue for random test failure from #4.

#3046697: \Drupal\Tests\views\Kernel\Entity\RowEntityRenderersTest::testRevisionBaseTable() can randomly fail

If test views do not have sorting options, they can return unstable results.

  • larowlan committed 2da5fec on 8.8.x 
    Issue #3046018 by claudiu.cristea: Convert SelectionTest into a Kernel...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 2da5fec and pushed to 8.8.x. Thanks!
c/p as e39882dd45 and pushed to 8.7.x

  • larowlan committed e39882d on 8.7.x 
    Issue #3046018 by claudiu.cristea: Convert SelectionTest into a Kernel...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.