"Limit list to selected items" on exposed filters does not filter

Hi @devad,

As the statement "Limit list to selected items" states that it should limit the items shown in the dropdown. It seems to be working fine as its properly filtering the dropdown. This checkbox "Limit list to selected items" only meant to limit the dropdown list not the result set as its an exposed filter and will act only when you select something. Hope this makes sense!

Thanks
Ashutosh

More accurate category and status.

Thanks,
-Derek

p.s. If you don't want the '- Any -' choice (which is what's giving you grief), you have to set that exposed filter to be 'Required'. That's really the problem you're hitting...

Understanding that this is working as intended but the InOperator filter contains code that should limit the "all" filter to the selected items:

if (empty($this->options['expose']['multiple']) && empty($this->options['expose']['required']) && !empty($this->options['expose']['limit'])) {
  $identifier = $this->options['expose']['identifier'];
  if ($input[$identifier] == 'All') {
    return TRUE;
  }
}

The related exposed filter form is assigning that value to reduce instead of limit:

$form['expose']['reduce'] = [
  '#type' => 'checkbox',
  '#title' => $this->t('Limit list to selected items'),
  '#description' => $this->t('If checked, the only items presented to the user will be the ones selected here.'),
  // Safety.
  '#default_value' => !empty($this->options['expose']['reduce']),
];

So, one possible work around would be to alter the value in a pre build hook:

/**
 * Implements hook_views_pre_build().
 */
function my_module_views_pre_build(ViewExecutable $view) {
  if ($view->id() === 'my_view_id') {
    $my_filter_id = 'my_filter_id';
    if (isset($view->filter[$my_filter_id]->options['expose']['reduce'])) {
      $view->filter[$my_filter_id]->options['expose']['limit'] = $view->filter[$my_filter_id]->options['expose']['reduce'];
    }
  }
}

Occasionally, I check the Drupal 8 issue queue and today was one of those days. Since Drupal 8 is no longer supported I am moving this to 11.x where it will be seen by the community. I am also removing the bug smash tag because that is added after the Bug Smash Initiative has triaged an issue.

Good morning everyone.

Comment #6 is right, I have tried what he says and he is right, thank you very much steyep.

I have created a fork branch and done mr to 10.2.x and 11.x.

Greetings to all.

Thanks for working on this old one.

Can the issue summary be updated using the standard issue template please

Changed to a bug as support requests typically don't have code fixes. But will need a test case showing the issue.

Hello, I have updated the summary as you suggested, I hope you like it, greetings.

Updated the issue summary to standard format, and added a better test script.

Not sure if you forgot to push but don’t see any test added to the MR

Wanted to comment that I got hit by this bug today and the MR does appear to work.

I had to rewrite the issue summary. The instructions were so vague it took 20-30 minutes of reading and testing to figure out what the problem is.

I left two comments on the MR. The change to the plugin is simple enough. The test looks good. But the documentation needs work.