By clicking button in popup link is not opening in new tab

CommentFileSizeAuthor
#13 3198247-13.patch528 byteskeerthana13
#6 externallink_popup_config.PNG14.01 KBkeerthana13
#6 3198247-6.patch3.59 KBkeerthana13
#2 3198247-2.patch451 byteskeerthana13

Comments

keerthana13 created an issue. See original summary.

keerthana13’s picture

keerthana13 commented
StatusFileSize
new 3198247-2.patch451 bytes
dewalt’s picture

dewalt commented

@keerthana13 please provide more details about steps to reproduce and environment (OS/browser). I've just tested - the URL opens in new tab if target link has attribute `target="_blank"`.

keerthana13’s picture

keerthana13 commented

Suppose link field is used in content type and external links are provided through this field and target attribute is not set. On clicking this link, external popup opens and when we click on continue it is opening in same tab instead of new tab. As we need all links opening through external link popup should open in new tab.

dewalt’s picture

dewalt commented
Category: Bug report » Feature request

@kerthana13 - it is expected behavior for now, described in documentation.

ATTENTION: Pop-up link target isn't configured in the module, pop-up uses
"target" attribute of the link to open link same/new window.

I'll think about configuration option to allow the links be opened on new tab if target is not set for the link

I assume that if the link is planned to be opened a new window it is already has target attribute set by content editor. But I agree that if the attribute isn't set before it could be hard to do it on all the content and an option could take place.

keerthana13’s picture

keerthana13 commented
StatusFileSize
new 3198247-6.patch3.59 KB
new externallink_popup_config.PNG14.01 KB

I added one checkbox "Open link in new tab" in configuration.

dewalt’s picture

dewalt commented
Status: Active » Needs review

  • dewalt committed f7e27e5 on 8.x-1.x authored by keerthana13 
    Issue #3198247 by keerthana13, dewalt: Link not opening in new tab
dewalt’s picture

dewalt commented
Status: Needs review » Reviewed & tested by the community

@keerthana13 I've commited the patch with small changes in the property key, its default value, added info to README. Please check and close the ticket if it works.

dewalt’s picture

dewalt commented
Status: Reviewed & tested by the community » Fixed
dewalt’s picture

dewalt commented
Version: 8.x-1.8 » 8.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

keerthana13’s picture

keerthana13 commented
StatusFileSize
new 3198247-13.patch528 bytes

Hi @dewalt.. I noticed u missed to update property key in entity php file due to which facing issue while checking the box and saving the configuration. I am attaching the patch for minor fixes. Please have a look.

dewalt’s picture

dewalt commented
Status: Closed (fixed) » Needs review
dewalt’s picture

dewalt commented
Status: Needs review » Needs work

Hi @keerthana13,

Please make sure you are using the latest version of the module. Applying the patch "Open in new tab by default" functionality stopped working on my side.

Please describe a case to reproduce an issue and changes the patch provides.

dewalt’s picture

dewalt commented
Status: Needs work » Closed (works as designed)

Closed due no activity