Problem/Motivation

This is a port of #3266176: Add normalizer for entity_reference_revisions module minus the ERR changes and also removing of mixed return type.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 hal-1.x-test-fixes-3303766-7-interdiff.txt1.16 KBberdir
#7 hal-1.x-test-fixes-3303766-7.patch7.84 KBberdir
#5 hal-1.x-test-fixes-3303766-5.patch9.52 KBberdir
#5 hal-1.x-test-fixes-3303766-5-interdiff.txt382 bytesberdir
hal-1.x-test-fixes.patch9.64 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Only 1.0.x is available for testing, but that's actually outdated and 1.x is the one that should be used, but that needs a test configuration.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I've added a test configuration for 1.x, removed the 1.0x and queued a run on the above

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Should this require Drupal 10 or 9?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new hal-1.x-test-fixes-3303766-5.patch9.52 KB
new hal-1.x-test-fixes-3303766-5-interdiff.txt382 bytes

Ah sorry, D9 obviously, we also don't need the require-dev's, forgot to update that.

Status: Needs review » Needs work

The last submitted patch, 5: hal-1.x-test-fixes-3303766-5.patch, failed testing. View results

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new hal-1.x-test-fixes-3303766-7.patch7.84 KB
new hal-1.x-test-fixes-3303766-7-interdiff.txt1.16 KB

Ok, weird. in D9, rest.resource.entity.node.yml is in hal module in core, and in D10, it was moved to rest module, so in hal 1.x, we actually don't need to change that, we can stay consistent with core hal module and keep the config.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Thanks - will commit this now

  • larowlan committed 8fa658d on 1.x authored by Berdir 
    Issue #3303766 by Berdir: Test fixes and PHP 7.4 compatibility
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Thanks, cutting 1.0.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.