Problem/Motivation

The ImagefieldSlideshowFieldFormatter.php file contains global service calls as per reported by phpcs.

Steps to reproduce

Run the phpcs command on the module.

Proposed resolution

Use the properties with injected services and inject the path_alias.manager service into the class.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3375274-2.patch4.34 KBsidharth_soman

Comments

sidharth_soman created an issue. See original summary.

sidharth_soman’s picture

sidharth_soman commented
Assigned: sidharth_soman » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3375274-2.patch4.34 KB

I have made the required changes. Please review the patch.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
Priority: Normal » Minor
Issue tags: +Novice

  • heykarthikwithu authored 87bd5893 on 2.x 
    Issue #3375274 by heykarthikwithu: \Drupal calls should be avoided in...

  • sidharth_soman authored 2215f661 on 2.x 
    Issue #3375274 by sidharth_soman: \Drupal calls should be avoided in...
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

Released in the 2.0.4 version.