Needs work
Project:
Klaro Cookie & Consent Management
Version:
3.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
11 Nov 2024 at 11:32 UTC
Updated:
19 Jun 2025 at 12:50 UTC
Jump to comment: Most recent
Comments
Comment #4
jan kellermann commented- We split up the list (enabled services / disabled services).
- You can change the order of enabled services.
- you can enable or disable via checkbox
Please review and feedback.
Comment #5
rkollerSorry took a little longer than anticipated, but my eye problems have flared up again, making longer text where you have to focus a bit cumbersome. I have taken a look at MR199 and played around with the merge request. I’ve noticed a few things:
Enabled servicesheading and its table underneath - that way the heading looks pushed towards theAdd servicebutton and the gap between the heading and the table is way bigger for theEnabled servicescompared to theDisabled services. It is probably due tomargin-block-startwithin the.tabledrag-toggle-weight-wrapperclass selector. I suppose due to the fact that the other pages that are using the enabled/disabled pattern don’t have the option to sort in consequence they also have don't have theShow row weightslink on top of the table, and the div that is containing that link has that margin causing the larger gap.Operationscolumn are way bigger than usual - they look like twice the height compared to the drop buttons on for exampleadmin/structure/display-modes/view,admin/structure/view, oradmin/content.EnableandDisableoptions on the drop buttons in theOperationscolumn.Save configurationbutton label and theStatuscolumn header are decoupled semantically from the section headingsEnabled servicesandDisabled services.No services have been created yet.. This is sort of inaccurate since Klaro is shipping with 23 services by default.In the following a few suggestion how to tackle the aforementioned points:
about point 1: If possible I would reduce the margin between the
Enabled servicesheading the associated table.about point 2: The other pages using the enable/disable pattern are using the extra small variant size for drop buttons from the Drupal Design System. I would suggest to stay consistent in regard to the styling.
about point 3: I would suggest to follow the pattern the other pages with the enable/disable pattern are using. Remove the status column and adjust the width of the remaining columns in-between the two tables. On the drop buttons of the
Enabled servicessection, keepEditthe default option and add aDisableoption as secondary action. In theDisabled servicessection makeEnablethe default option on the drop button and moveEditto the secondary actions. If you enable a disabled service it is directly moved to the enabled services section, same as the other way around.The only slightly “odd” detail about that pattern is having those handles for changing the order of enabled services by dragging them vertically. My first impulse was testing if it would be possible to disable services by drag and drop. But it was clearly communicated that dragging a service to a different section doesn't work/is not intended AND the disabled services section doesn't have those handles.
about point 4: Uncertain if it might be too granular, but the most accurate approach would be to check if there are no services created yet and then show
No services have been created yet.in the enabled as well as the disabled services section. If there are services created, and none of them is enabled use something likeThere are no enabled services.in the enabled services section, if none of them is disabled use something likeThere are no disabled services.in the disabled services section.Comment #6
rkollerComment #7
jan kellermann commented