When having a table/text formatter with closed days and empty days with comment, Both the 'Closed' word and the comments are in different columns.
Move the Closed word to the Comment column if Comments are enabled.

DayTime slotComment
Sunday - Monday:	Closed	<td class="office-hours__item-slots">Closed</td>
Tuesday:		gesloten           <td class="office-hours__item-comments">gesloten</td>
Wednesday - Saturday:	Closed
CommentFileSizeAuthor
#5 office_hours_3152911-5_move-closed-text-to-comments.patch5.26 KBjohnv
#3 with_no_comments.png16.12 KBlarisse
#3 with_comments.png17.92 KBlarisse
#3 3152911-3.patch1.32 KBlarisse

Comments

johnv created an issue. See original summary.

johnv’s picture

johnv
Primary language Dutch
commented
Title: Move 'Closed text' to Comment column if enabled. » Move 'Closed text' to Comment column if enabled
larisse’s picture

larisse commented
Status: Active » Needs review
StatusFileSize
new 3152911-3.patch1.32 KB
new with_comments.png17.92 KB
new with_no_comments.png16.12 KB

Hi! I made a patch to do solve this.
My idea was set a value, like xx-xx in table in empty days. Doing this, I can put the text 'Closed' in the same column of comments.
The way I made, the text 'Closed' is put even if the comments are unable, but if the comments are able, the comment is put in the same column where hours are (like was working).

I will put the images for see how are when apply the patch. I don't know if has a better way to do it, but if anyone has any idea, I'm open to work in this. :)

johnv’s picture

johnv
Primary language Dutch
commented
Category: Bug report » Feature request
johnv’s picture

johnv
Primary language Dutch
commented
Priority: Normal » Minor
StatusFileSize
new office_hours_3152911-5_move-closed-text-to-comments.patch5.26 KB

Thanks, sorry for the delay.

Attached patch takes another approach, using php, not twig.
I am not sure about the wanted behaviour of if ($formatted_slot || $item_comments) {
Also not sure about the benefits of the change.

Curious for user feedback.