Hello,
currently there is no possibility to alter build array of block which renders through Panels module. In PanelsDisplayVariant.php we have a method buildRegions which render available blocks, so it would be very useful to get hook_alter similar to BlockViewBuilder so other modules will have a way to affect on block build array.

CommentFileSizeAuthor
#20 alter_block_during-2559533-20.patch6.16 KBpiggito
#20 interdiff.txt862 bytespiggito
#19 interdiff-0b2337.txt1003 bytesjibran
#18 alter_block_during-2559533-18-4.x.patch5.58 KBjibran
#18 alter_block_during-2559533-18.patch5.54 KBjibran
#15 alter_block_during-2559533-15-4.x.patch5.59 KBjibran
#15 alter_block_during-2559533-15.patch5.55 KBjibran
#12 alter_block_during-2559533-12.patch5.55 KBwelly
#9 alter_block_during-2559533-9.patch4.49 KBwelly
#7 alter_block_during-2559533-7.patch4.52 KBwelly
#5 alter_block_during-2559533-5.patch2.5 KBwelly
#2 edit_alter_block_during-2559533-1.patch2.64 KBwelly
#22 interdiff.txt975 bytespiggito
#22 alter_block_during-2559533-21.patch6.15 KBpiggito

Comments

shumer created an issue. See original summary.

welly’s picture

welly commented
Status: Active » Needs review
StatusFileSize
new edit_alter_block_during-2559533-1.patch2.64 KB

I needed this very thing this morning on a project. Together with jibran, we've come up with a patch. Can we get a review?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Related issues: +#2617996: Support hook_block_build_alter() and hook_block_view_alter()

Status: Needs review » Needs work

The last submitted patch, 2: edit_alter_block_during-2559533-1.patch, failed testing.

welly’s picture

welly commented
Status: Needs work » Needs review
StatusFileSize
new alter_block_during-2559533-5.patch2.5 KB

Fixed patch

Status: Needs review » Needs work

The last submitted patch, 5: alter_block_during-2559533-5.patch, failed testing.

welly’s picture

welly commented
Status: Needs work » Needs review
StatusFileSize
new alter_block_during-2559533-7.patch4.52 KB

Patch updated to inject dependency into InPlaceEditorDisplayBuilder class

Status: Needs review » Needs work

The last submitted patch, 7: alter_block_during-2559533-7.patch, failed testing.

welly’s picture

welly commented
StatusFileSize
new alter_block_during-2559533-9.patch4.49 KB

Let's try again.

welly’s picture

welly commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: alter_block_during-2559533-9.patch, failed testing.

welly’s picture

welly commented
StatusFileSize
new alter_block_during-2559533-12.patch5.55 KB

Fixed failed test (hopefully)

welly’s picture

welly commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: alter_block_during-2559533-12.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Version: 8.x-3.x-dev » 8.x-4.x-dev
Status: Needs work » Needs review
StatusFileSize
new alter_block_during-2559533-15.patch5.55 KB
new alter_block_during-2559533-15-4.x.patch5.59 KB

The last submitted patch, 15: alter_block_during-2559533-15.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 15: alter_block_during-2559533-15-4.x.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new alter_block_during-2559533-18.patch5.54 KB
new alter_block_during-2559533-18-4.x.patch5.58 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-0b2337.txt1003 bytes
piggito’s picture

piggito commented
StatusFileSize
new alter_block_during-2559533-20.patch6.16 KB
new interdiff.txt862 bytes

I'm adding a patch to include hook_block_build_alter too.

The last submitted patch, 20: alter_block_during-2559533-20.patch, failed testing. View results

piggito’s picture

piggito commented
StatusFileSize
new alter_block_during-2559533-21.patch6.15 KB
new interdiff.txt975 bytes

I made a mistake in my last patch, I'm adding the correct one.

andyf’s picture

andyf commented
Title: Alter block during render process. » Support hook_block_build_alter() and hook_block_view_alter()
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Category: Feature request » Task
Status: Needs review » Reviewed & tested by the community

I don't think it is a feature request and it's not a bug it is just a missing functionality so I changed it to a task. Core has hook specific tests to verify the implementation is working correctly but I have not seen this practice in contrib so I think with a green patch it is RTBC.

samuel.mortenson credited samuel.mortenson.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This makes a lot of sense, and doesn't seem to interfere with my existing Panels sites. Thank all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.