We need the ability to schedule the report to run on cron (if the user wants it).

Comments

WidgetsBurritos created an issue. See original summary.

WidgetsBurritos’s picture

Assigned: Unassigned » WidgetsBurritos
Priority: Normal » Minor
WidgetsBurritos’s picture

Assigned: WidgetsBurritos » pobster
Status: Active » Needs review
StatusFileSize
new4.21 KB

This patch adds an admin page and the ability to turn cron on/off and adjust the interval.

pobster’s picture

I'd maybe suggest using a select for the time period as core module tend to, this is lifted from aggregator;

  $period = drupal_map_assoc(array(900, 1800, 3600, 7200, 10800, 21600, 32400, 43200, 64800, 86400, 172800, 259200, 604800, 1209600, 2419200), 
 'format_interval');
  $period[0] = t('Never');

Also it makes a lot of sense to slim the module files themselves as much as possible as they're always loaded into memory. Every little helps so would recommend moving out the admin functions to a separate file, e.g. "panels_pane_report.admin.inc" with a reference in hook_menu.

pobster’s picture

Assigned: pobster » WidgetsBurritos
WidgetsBurritos’s picture

Assigned: WidgetsBurritos » pobster
StatusFileSize
new4.85 KB

@pobster Okay how about now?

WidgetsBurritos’s picture

StatusFileSize
new4.2 KB

Now with fewer variables.

pobster’s picture

Assigned: pobster » WidgetsBurritos
Status: Needs review » Reviewed & tested by the community

Looks great, thanks! +1

WidgetsBurritos’s picture

Status: Reviewed & tested by the community » Fixed
WidgetsBurritos’s picture

Status: Fixed » Closed (fixed)