Add a test that ensures drop down filters match database table values.

CommentFileSizeAuthor
#7 test_filters-2849677-7.patch2.45 KBWidgetsBurritos
#7 interdiff-7.txt1.7 KBWidgetsBurritos
#5 interdiff-5.txt956 bytesWidgetsBurritos
#5 test_filters-2849677-5.patch3.04 KBWidgetsBurritos
#4 test_filters-2849677-4.patch3.26 KBWidgetsBurritos
#4 interdiff.txt1013 bytesWidgetsBurritos
#2 panels-pane-report-web-tests-filters-2849677-2.patch3.26 KBWidgetsBurritos

Comments

WidgetsBurritos created an issue. See original summary.

WidgetsBurritos’s picture

WidgetsBurritos commented
Status: Active » Needs review
StatusFileSize
new panels-pane-report-web-tests-filters-2849677-2.patch3.26 KB

Status: Needs review » Needs work

The last submitted patch, 2: panels-pane-report-web-tests-filters-2849677-2.patch, failed testing.

WidgetsBurritos’s picture

WidgetsBurritos commented
Assigned: Unassigned » bighappyface
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1013 bytes
new test_filters-2849677-4.patch3.26 KB

Helps if I point the test at the right page...

WidgetsBurritos’s picture

WidgetsBurritos commented
StatusFileSize
new test_filters-2849677-5.patch3.04 KB
new interdiff-5.txt956 bytes

Just a minor tweak. Removing a redundant function here.

bighappyface’s picture

bighappyface commented 
+++ b/tests/PanelsPaneReportWebTestCase.test
@@ -105,4 +106,49 @@ class PanelsPaneReportWebTestCase extends DrupalWebTestCase {
+    $this->assertRaw('<option value="retriever">retriever</option>', 'Has a retriever puppy.');

Wouldn't that message be misleading? If the check is that the retrieve option is there, and the assertion fails, then the message "Has a retriever puppy." would be incorrect, no? Why even set the messages for assertRaw? The default messaging is better than assertTrue and indicates exactly what it was looking for.

WidgetsBurritos’s picture

WidgetsBurritos commented
StatusFileSize
new interdiff-7.txt1.7 KB
new test_filters-2849677-7.patch2.45 KB

@bighappyface good call. I've updated it. Additionally, I removed some of those `assertNoRaw()` commands because they didn't really make a whole lot of sense.

bighappyface’s picture

bighappyface commented
Status: Needs review » Reviewed & tested by the community

+1 LGTM

WidgetsBurritos’s picture

WidgetsBurritos commented
Status: Reviewed & tested by the community » Fixed
WidgetsBurritos’s picture

WidgetsBurritos commented
Status: Fixed » Closed (fixed)