After fixing the tests with #1764516: Repeated functions / Syntax error., if the deploy module is not downloaded, the tests fail when trying to enable it. Also there is a test case (Import UUID entities, without deploy) that depends on entity and features and has the same problem.

Proposed solution:
Add a dependencies key to the tests that use this module so they don't get executed when it's not there.

Note that this won't affect the behavior of the test bot since it automatically detects and downloads the dependency.

CommentFileSizeAuthor
#1 uuid-add_tests_optional_dependencies-1777980-1.patch1.31 KBlucascaro

Comments

lucascaro’s picture

lucascaro commented
StatusFileSize
new uuid-add_tests_optional_dependencies-1777980-1.patch1.31 KB

Attached is a patch that does what I mentioned. Note that the tests are still failing (in particular the tests on UUIDSyncTestCase) but that deserves a different issue IMHO.

lucascaro’s picture

lucascaro commented
Status: Active » Needs review
lucascaro’s picture

lucascaro commented
Assigned: Unassigned » lucascaro
mgifford’s picture

mgifford
he/him
Primary language English
commented

Patch still applies nicely to the git repo. This seems like a nice simply improvement to the testing infrastructure, but not sure what's the best way to test this to mark it RTBC. Is it simply running this module's simpletests?

lambic’s picture

lambic commented

After applying the patch I still get 2 failures in UUIDImportEntitiesWithoutDeploy:

Fail Other uuid.test 635 UUIDImportEntitiesTestCase->testImp
uuid_entities in uuid_default_entities_example had state: default

Fail Other uuid.test 659 UUIDImportEntitiesTestCase->testImp
uuid_entities in uuid_default_entities_example had state: default

But this patch fixes the more fatal failures.

Status: Needs review » Needs work

The last submitted patch, 1: uuid-add_tests_optional_dependencies-1777980-1.patch, failed testing.