A while ago, I tried to get Webform Rules to resolve the conflicting use of the webform token namespace. We were making some progress, but then Webform 4 came out, the token formats changed, and so on, and it never happened.

I want to resolve this incompatibility, once and for all, so I am changing Webform Tokens' token namespace to webform-tokens.

This is only a breaking change when Webform Rules is enabled, and there is a note about this on the project page. That's why it's not in a new branch.

We will be integrating with Webform's own token type soon, anyway, so this didn't merit a new version. The 7.x-2.x branch will contain the behavior switch, since that by any stretch will be a breaking change.

What this means: If you use [webform:] tokens right now that Webform Tokens provides, and you use Webform Rules, you must switch to [webform-tokens:].

If you don't use Webform Rules, you shouldn't notice anything. You should try to stick to [webform-tokens:] tokens from now on, though.

Comments

wizonesolutions’s picture

Status: Active » Fixed
StatusFileSize
new1.9 KB

Committed in 45b346d0e8466f9f0fcd67cfcb0fbc7705d57fbe

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

liam morland’s picture

Category: Task » Bug report
Issue summary: View changes
Status: Closed (fixed) » Active
liam morland’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Halim_61’s picture

Unfortunately this update breaks backward compatibility with webform 3.x and fillpdf 7.1.9. Unfortunately last patch is included in latest stable release. Please consider to revoking the token renaming patch or fix the compatibility as stated in your release notes. BTW.: we don't use webform rules module here. Thx.

liam morland’s picture

This one has gone back and forth. We need some people who used Webform 3 with and without Webform Rules to figure out a solution to this. I don't use Webform 3 or Webform Rules, so I don't think I have much to offer here.

wizonesolutions’s picture

OK, I see your situation. Honestly the easiest solution is to update to Webform 4 unless you are sure it breaks something. Otherwise, you can submit a patch to FillPDF to support the webform-tokens token type. It's really trivial.

You could also use an older version of Webform Tokens before we made the change. I'm not sure why that was working if it was, but if it was then I recommend staying on that. This module is deprecated, so there is not much point in continuing to support old module combinations and risk breaking things.

Patches welcome of course.

liam morland’s picture

@Halim_61: 7.x-1.4 is the same as 7.x-1.5 except for the change in this issue, so that is probably the one you want.